From f4c4d6928b6f264714f2da417afa64322ce47675 Mon Sep 17 00:00:00 2001
From: marcobaobao <marco.piovanello@gmail.com>
Date: Fri, 7 Jun 2024 11:19:17 +0200
Subject: [PATCH] code refactoring

---
 server/internal/process.go | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/server/internal/process.go b/server/internal/process.go
index e69ce43..74683a8 100644
--- a/server/internal/process.go
+++ b/server/internal/process.go
@@ -82,6 +82,9 @@ func (p *Process) Start() {
 
 	buildFilename(&p.Output)
 
+	//TODO: it spawn another one yt-dlp process, too slow.
+	go p.GetFileName(&out)
+
 	baseParams := []string{
 		strings.Split(p.Url, "?list")[0], //no playlist
 		"--newline",
@@ -122,8 +125,6 @@ func (p *Process) Start() {
 
 	p.proc = cmd.Process
 
-	go p.SetMetadata()
-
 	// --------------- progress block --------------- //
 	var (
 		sourceChan = make(chan []byte)
@@ -272,7 +273,6 @@ func (p *Process) GetFormatsSync() (DownloadFormats, error) {
 	return info, nil
 }
 
-// TODO: remove, potentially unused
 func (p *Process) GetFileName(o *DownloadOutput) error {
 	cmd := exec.Command(
 		config.Instance().DownloaderPath,
@@ -302,12 +302,7 @@ func (p *Process) SetPending() {
 }
 
 func (p *Process) SetMetadata() error {
-	cmd := exec.Command(
-		config.Instance().DownloaderPath,
-		p.Url,
-		"-J",
-		"-o", fmt.Sprintf("%s/%s", p.Output.Path, p.Output.Filename),
-	)
+	cmd := exec.Command(config.Instance().DownloaderPath, p.Url, "-J")
 	cmd.SysProcAttr = &syscall.SysProcAttr{Setpgid: true}
 
 	stdout, err := cmd.StdoutPipe()
@@ -354,14 +349,13 @@ func (p *Process) SetMetadata() error {
 		return err
 	}
 
+	p.Info = info
+	p.Progress.Status = StatusPending
+
 	if err := cmd.Wait(); err != nil {
 		return errors.New(bufferedStderr.String())
 	}
 
-	p.Info = info
-	p.Progress.Status = StatusPending
-	p.Output.SavedFilePath = info.FileName
-
 	return nil
 }